RFR: 8146990: Convert CollectorPolicy to use log_warning instead of warning
Stefan Johansson
stefan.johansson at oracle.com
Wed Jan 13 15:06:46 UTC 2016
Hi Erik,
Thanks for doing this improvement.
On 2016-01-13 15:24, Erik Helin wrote:
> Hi all,
>
> this patchs updates CollectorPolicy to use log_warning(gc, ergo) instead of
> warning (as part of updating the GC code to use unified logging).
>
> Enhancement:
> https://bugs.openjdk.java.net/browse/JDK-8146990
>
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8146990/00/webrev/
src/share/vm/gc/shared/collectorPolicy.cpp:
700 log_warning(gc,
ergo)("GenCollectorPolicy::mem_allocate_work retries %d times \n\t"
701 " size=" SIZE_FORMAT " %s",
try_count, size, is_tlab ? "(TLAB)" : "");
873 log_warning(gc, ergo)("satisfy_failed_metadata_allocation()
retries %d times \n\t"
874 " size=" SIZE_FORMAT, loop_count,
word_size);
After UL we avoid having multi-line logging statements. So I suggest you
either re-format these to only use a single line each.
---
Otherwise the change looks good.
Thanks,
Stefan
> Testing:
> - JPRT
>
> Thanks,
> Erik
More information about the hotspot-gc-dev
mailing list