RFR: 8134963 [Newtests] New tests for G1 remembered set up and down

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jan 14 12:54:08 UTC 2016


Hi again,

  some further notes:

- maybe remove the "up and down" from the CR title. To me it just
sounds strange, and whenever I see this title, I ask myselves what
making a remembered set go "up" or "down" means.

On Thu, 2016-01-14 at 13:49 +0100, Thomas Schatzl wrote:
> Hi Dima,
> 
> On Wed, 2015-12-30 at 19:43 +0300, Dmitry Fazunenko wrote:
> > Hi everyone,
> > 
> > An updated version of the stress test for Remembered Set:
> >     http://cr.openjdk.java.net/~dfazunen/8134963/webrev.03/
> > 
> > Tested in RBT in many configurations.
> > Many thanks to Thomas for his offline comments.
[...]
> 
> - line 200-202: the thresholds are automatically calculated, based on
> region size and options.
> See OtherRegionsTable::OtherRegionsTable for the fine->coarse
> threshold
> (_max_fine_entries), and SparsePRT::cards_num() for an entry point
> for
> the sparse->fine threshold.
> 
> Maybe they should be retrieved from the corresponding VM global.

Note that changes here may make JDK-8147087 unreproducable. Can you
check that this is not the case if you change something here?

It would be nice to use this test as a fairly good reproducer for JDK
-8147087.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list