RFR (M): 8146987: Improve Parallel GC Full GC by caching results of live_words_in_range() [Was: Re: [PATCH] enhancement to ParallelScavenge Full GC]

[Mikael Gerdin]

Hi,

On 2016-01-15 12:43, Thomas Schatzl wrote:
> Hi all,
>
> On Thu, 2016-01-14 at 13:04 -0800, Jon Masamitsu wrote:
>> http://cr.openjdk.java.net/~tschatzl/8146987/webrev.1/src/share/vm/gc
>> /parallel/psCompactionManager.hpp.frames.html
>>
>> Please initialize these in the constructor
>>
>> 112 HeapWord* _last_query_beg;
>> 113 oop _last_query_obj;
>> 114 size_t _last_query_ret;
>>
>> http://cr.openjdk.java.net/~tschatzl/8146987/webrev.1/src/share/vm/oo
>> ps/oop.hpp.udiff.html
>>
>> Any reason to use "pc" as the parameter name here and
>> not "cm" as is used elsewhere?
>>
>> - void pc_update_contents();
>> + void pc_update_contents(ParCompactionManager* pc);
>>
>
>    new webrevs (also including Mikael's comments) at
>
> http://cr.openjdk.java.net/~tschatzl/8146987/webrev.2/ (full)
> http://cr.openjdk.java.net/~tschatzl/8146987/webrev.1_to_2/ (diff)

Looks ok to me.
/Mikael

>
> Thanks,
>    Thomas
>