RFR (S): 8141421: Various test fail with OOME on win x86

[Mikael Gerdin]

Hi Derek,

On 2016-01-19 18:38, Derek White wrote:
> This is a small fix for a (malloc) memory leak that is causing a variety
> of crashes.
>
> This also improves memory tracking slightly, and adds asserts that
> clarify the expected locking usage of g1CodeCacheRemSet.
>
> *BUG*: JDK-8141421 Various test fail with OOME on win x86
> *Webrev*: http://cr.openjdk.java.net/~drwhite/8141421/webrev.00/

The fix looks good, but I have a question with regard to the leak itself.
Is it a leak in the sense that the memory never actually gets freed?
It appears to me that calling move_to_large several times, while not 
optimal, would still put the previous value of _table on the purge list, 
pending deallocation by a call to purge().
In that case, is it the sudden spike of memory usage that causes the OOM 
situations and not that the memory would never be freed?

Either way, good catch!

/Mikael

> *Testing* jprt, aurora.
>
>   - Derek
>
> NOTE: Still tracking down if this fixes all failures noted in 8141421:
>
>     +RULE "runtime/6819213/TestBootNativeLibraryPath.java" Crash Out of
>     Memory Error ...allocation.inline.hpp...
>     +RULE "runtime/6819213/TestBootNativeLibraryPath.java" ExitCode 1
>     RULE "runtime/Metaspace/FragmentMetaspace.java" Crash Out of Memory
>     Error ...allocation.inline.hpp...
>     RULE "runtime/Metaspace/FragmentMetaspace.java" ExitCode 1
>     RULE
>     "vm/runtime/contended/tests/genereated/GeneratedClassTest_1_20_10000_10_0.75d"
>     Crash Out of Memory Error ...allocation.inline.hpp...
>     RULE
>     "vm/runtime/contended/tests/genereated/GeneratedClassTest_1_20_10000_10_0.75d"
>     ExitCode 1
>     RULE
>     "vm/runtime/contended/tests/genereated/GeneratedClassTest_20_100_512_20_0.75d"
>     Crash Out of Memory Error ...allocation.inline.hpp...
>     RULE
>     "vm/runtime/contended/tests/genereated/GeneratedClassTest_20_100_512_20_0.75d"
>     ExitCode 1
>     RULE "jdk/lambda/vm/InterfaceAccessFlagsTest.java" Crash Out of
>     Memory Error ...allocation.inline.hpp...
>     RULE "jdk/lambda/vm/InterfaceAccessFlagsTest.java" ExitCode 1
>     RULE "tools/launcher/ArgsFileTest.java" Crash Out of Memory Error
>     ...allocation.inline.hpp...
>     RULE "tools/launcher/MultipleJRERemoved.java" Crash Out of Memory
>     Error ...allocation.inline.hpp...
>     RULE "tools/launcher/TestMainWithoutEnclosing.java" Crash Out of
>     Memory Error ...allocation.inline.hpp...
>     RULE "tools/launcher/UnresolvedExceptions.java" Crash Out of Memory
>     Error ...allocation.inline.hpp...
>     RULE
>     "vm/runtime/contended/tests/genereated/GeneratedClassTest_20_100_10000_10_0.75d"
>     Crash Out of Memory Error ...allocation.inline.hpp...
>     java\lang\instrument\ManyMethodsBenchmarkAgent.java
>
>     This may also fix:
>     JDK-8134889 Kitchensink stress test crashes with out of memory error
>     JDK-8134747 ParallelClassLoading tests run out of memory on win32
>     8134992 vm/gc/compact/Compact_InternedStrings_Strings failed due to
>     a malloc() failure
>