RFR: 8147814: Move verification code out of g1collectedheap

[David Lindholm]

Jesper,

Thanks for looking at this!

On 2016-01-20 18:08, Jesper Wilhelmsson wrote:
> Hi,
>
> concurrentMark.cpp should #include g1HeapVerifier.hpp, right?

Yes. Thanks, I'll fix.

> Do G1CollectedHeap have to be a friend of G1HeapVerifier?

Yes, there are a number of private variables in g1collectedheap that is 
needed by the verifier, but I don't want to expose those via getters.

> Otherwise looks good!

Thanks. Do you need another webrev?

Thanks
David

> /Jesper
>
>
> Den 20/1/16 kl. 15:57, skrev David Lindholm:
>> Hi,
>>
>> After offline discussion I decided to do only the verification code 
>> move in this
>> change. Please see the new webrev:
>>
>> http://cr.openjdk.java.net/~david/JDK-8147814/webrev.01/
>>
>>
>> Thanks,
>> David
>>
>> On 2016-01-20 14:49, David Lindholm wrote:
>>> Hi.
>>>
>>> As a first step in the technical debt task of splitting the enormous
>>> g1CollectedHeap class into smaller units I have moved allocation 
>>> code to the
>>> g1Allocator class, and created a new class called g1HeapVerifier and 
>>> moved all
>>> verification code there.
>>>
>>> Could I please have a couple of reviews for this patch?
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8147814
>>> Webrev: http://cr.openjdk.java.net/~david/JDK-8147814/webrev.00/
>>>
>>>
>>> Thanks,
>>> David
>>