RFR: 8141278: New tests for PLAB testing

[Thomas Schatzl]

Hi Michail,

On Tue, 2016-01-19 at 20:11 +0300, Michail Chernov wrote:
> Hi Thomas,
> 
> Thanks a lot for your comment!
> 
> Updated webrev
> http://cr.openjdk.java.net/~mchernov/8141278/webrev.01/
> http://cr.openjdk.java.net/~mchernov/8141278/webrev.01_to_00/
> 
> See comments below:
> 
> On 14.01.2016 17:04, Thomas Schatzl wrote:
> > General comments:
> > 
> > - would it help if the PLAB logging would print out what generation
> > the
> > particular output is for? That would probably make the code easier
> > to
> > understand than the current way of filtering out every second
> > printout
> > (and potentially decrease the size of LogParser a lot).
> Yes, it would be good. Appropriate CR was created couple months ago: 
> https://bugs.openjdk.java.net/browse/JDK-8141141

That was a more or less veiled question whether you wanted to do this ;
-)

[...]
> > - maybe the TestCase class could (but possibly should not?) be 
> > merged in some wa that the TestCase for PLABResize seems to be a
> > part of the TestCase or PLABNoResize

> Don't think that there are two similar cases. It can be one class,
> but it will have a lot of extra unnecessary code for both cases.This
> class will not store than a given number of objects...

Okay, fair enough.

> > The Storage class ...
> > This class will not store than a given number of objects...
> > If its capacity is exceeded, old objects will be overwritten.
> > E.g. if capacity is one, only the last object added will be saved.
>
> Storage was renamed to MemoryConsumer. Also comments were  fixed.
>

There is one remaining reference in line 60 in MemoryConsumer.java.

Looks okay otherwise. I do not need another review cycle for this
change.

Thanks,
  Thomas