ping: RFR(L): 8146395: Add inline qualifier in oop.hpp and fix inlining in gc files

[Stefan Karlsson]

Hi Goetz,

I've sent your patch to JPRT, but there's a few patches before in the 
queue and one of them might conflict with your patch ...

StefanK

On 2016-01-27 09:08, Lindenmaier, Goetz wrote:
> Hi,
>
> could somebody please sponsor this change?
> http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-gc/webrev.03/
> I double checked that this webrev still applies nicely.
>
> Thanks and best regards,
>   Goetz.
>
>> -----Original Message-----
>> From: Lindenmaier, Goetz
>> Sent: Donnerstag, 21. Januar 2016 11:14
>> To: 'Mikael Gerdin' <mikael.gerdin at oracle.com>; hotspot-gc-
>> dev at openjdk.java.net
>> Subject: RE: ping: RFR(L): 8146395: Add inline qualifier in oop.hpp and fix
>> inlining in gc files
>>
>> Hi Mikael,
>>
>> thanks for looking at this!
>> I updated the copyrights and added Stefan and you as reviewers:
>> http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-gc/webrev.03/
>> So I think this could be pushed now.
>>
>> I'll ping again once I see 'real' changes popping up in rt.
>>
>> Best regards,
>>    Goetz.
>>
>>
>>> -----Original Message-----
>>> From: Mikael Gerdin [mailto:mikael.gerdin at oracle.com]
>>> Sent: Donnerstag, 21. Januar 2016 10:50
>>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-gc-
>>> dev at openjdk.java.net
>>> Subject: Re: ping: RFR(L): 8146395: Add inline qualifier in oop.hpp and fix
>>> inlining in gc files
>>>
>>> Hi Goetz,
>>>
>>> On 2016-01-21 09:37, Lindenmaier, Goetz wrote:
>>>> Hi,
>>>>
>>>> I please need a second reviewer for this change, as well as a sponsor.
>>>>
>>>> The current webrev incorporating Stefan's comments and a fix to
>>>> g1OopClosures.hpp
>>>>
>>>> is this:
>>>> http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-
>> gc/webrev.02/
>>> I think this looks good, I do have one comment though.
>>> New files, even if they consist of content moved from an existing file,
>>> should have their copyright years set to 2016 only.
>>>
>>> Note that we are attempting to stabilize hs-rt right now since we've
>>> seen a lot of test failures recently so there may be a slight delay in
>>> pushing this fix. It might be a good idea to ping the list about
>>> sponsoring this change if you don't hear back since it's easy to loose
>>> track of it now that it's reviewed and done.
>>>
>>> /Mikael
>>>
>>>> Best regards,
>>>>
>>>>     Goetz.
>>>>
>>>> *From:*hotspot-gc-dev [mailto:hotspot-gc-dev-
>>> bounces at openjdk.java.net]
>>>> *On Behalf Of *Lindenmaier, Goetz
>>>> *Sent:* Mittwoch, 13. Januar 2016 23:54
>>>> *To:* hotspot-gc-dev at openjdk.java.net
>>>> *Subject:* RFR(L): 8146395: Add inline qualifier in oop.hpp and fix
>>>> inlining in gc files
>>>>
>>>> Hi
>>>>
>>>> This change finishes the cleanup started in "8146401: Clean up oop.hpp:
>>>> add inline directives and fix header files"
>>>>
>>>> by fixing the issues in gc files.  See also
>>>> https://bugs.openjdk.java.net/browse/JDK-8146395 and the discussion
>>>>
>>>> of this change in the rt mailing list:
>>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-
>>> January/017440.html
>>>> Most issues can be fixed by including the proper .inline.hpp header or
>>>> moving a function there.
>>>>
>>>> I added new files src/share/vm/gc/shared/referenceProcessor.inline.hpp
>>>> and g1SATBCardTableModRefBS.inline.hpp.
>>>>
>>>> I moved the following methods to their .cpp files. In case someone
>>>> considers these
>>>>
>>>> performance relevant, I will add an inline.hpp file for them:
>>>>
>>>>     PromotedObject::next and ::setNext    --> promotionInfo.cpp
>>>>
>>>>     ObjectStartArray::object_start        --> objectStartArray.cpp
>>>>
>>>>     FillClosure::do_addr to               --> psParallelCompact.cpp (ok,
>>>> only used here)
>>>>
>>>>     ageTable::add                         --> ageTable.cpp
>>>>
>>>>     KlassSizeStats::count_array / ::count --> heapInspection.cpp
>>>>
>>>> Please review this change.  I please need a sponsor.
>>>>
>>>> http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-
>> gc/webrev.01/
>>>> Best regards,
>>>>
>>>>     Goetz Lindenmaier
>>>>
>>>> (The webrev messed up some change comments, the diffs and patch are
>>>> fine, though.)
>>>>