RFR(xs): 8161552: Test issue: VM init failed: GC triggered before VM initialization completed. Try increasing NewSize, current value 768K.

[Dmitry Fazunenko]

Thank you, Thomas!

On 21.07.2016 15:13, Thomas Schatzl wrote:
> Hi Dima,
>
> On Thu, 2016-07-21 at 15:05 +0300, Dmitry Fazunenko wrote:
>> Thomas,
> [...]
>>>> Updated version:
>>>> http://cr.openjdk.java.net/~dfazunen/8161552/webrev.01/
>>>> http://cr.openjdk.java.net/~dfazunen/8161552/webrev.00vs01/
>>>>
>>>    - line 37 contradicts with the new line 54 now. It's probably
>>> best to
>>> only remove the "(2m)" in line 37.
>> fixed.
>>>
>>>    - I would also prefer if the comment were as neutral as possible,
>>> i.e.
>>>    please remove the "rather strange" adjective in line 48.
>> agree, fixed.
>>>    - not sure what a "positive check" is (compared to what?), but
>>> just
>>> saying "Therefore we start the VM with 4M heap." would be fine.
>> Oh, it was my fault. I mixed this test up with another one, which
>> comprises both positive and negative checks.
>> Fixed as you suggested.
>>
>> http://cr.openjdk.java.net/~dfazunen/8161552/webrev.02/
>> http://cr.openjdk.java.net/~dfazunen/8161552/webrev.01vs02/
>>
>> Thanks a lot for verifying me.
>    ship it :)
>
> Thomas
>