RFR: 8156032: Clean up parallel GC specific code from vm/gc/shared/preservedMarks.cpp

[Stefan Karlsson]

Hi Leonid,

Thanks for cleaning this up!

See comments inlined:

On 2016-06-07 15:35, Leonid Mesnik wrote:
> Hi
>
> Could you please review following patch which remove PS specific code 
> from vm/gc/shared.
> Webrev: http://cr.openjdk.java.net/~lmesnik/8156032/webrev.00/ 
> <http://cr.openjdk.java.net/%7Elmesnik/8156032/webrev.00/>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8156032

http://cr.openjdk.java.net/~lmesnik/8156032/webrev.00/src/share/vm/gc/parallel/psPromotionManager.cpp.udiff.html
http://cr.openjdk.java.net/~lmesnik/8156032/webrev.00/src/share/vm/gc/shared/preservedMarks.hpp.udiff.html

+class PSPreservedMarksTaskExecutor : public 
RestorePreservedMarksTaskExecutor

+class SharedPreservedMarksTaskExecutor : public 
RestorePreservedMarksTaskExecutor


Should the subclasses also mention the word Restore?

------

http://cr.openjdk.java.net/~lmesnik/8156032/webrev.00/src/share/vm/gc/shared/preservedMarks.hpp.udiff.html

+public:
+ WorkGang* workers;
+


workers should be private and named _workers.

---

+ void restore(PreservedMarksSet* preserved_marks_set,
+ volatile size_t* total_size_addr);

Would you mind aligning the parameters?

---

+ // Iterate over all stacks, restore all preserved marks, and reclaim
+ // the memory taken up by the stack segments.
+ // Supported executors: WorkerPresevedMarksTaskExecutor (Serial, CMS, G1),
+ // PSManagerTaskExecutor (PS).


The comment refers to the old names of subclasses of 
RestorePreservedMarksTaskExecutor.

Thanks,
StefanK

>
> Fix is tested with JPRT.
>
> Leonid