Request for Review (xs) - 8159073: Error handling incomplete when creating GC threads lazily

Erik Helin erik.helin at oracle.com
Thu Jun 9 08:33:12 UTC 2016


On 2016-06-08, Jon Masamitsu wrote:
> https://bugs.openjdk.java.net/browse/JDK-8159073
> 
> The error handling in add_workers() was not treating the non-initializing
> case correctly.  If in the non-initializing case, it is OK to fail the
> creation
> of additional threads but the number of created threads should not be
> incremented nor non-existent thread started.
> 
> http://cr.openjdk.java.net/~jmasa/8159073/webrev.00/

Should we add some logging in case the code fail to create a worker
thread (in the non initializing case)?

Thanks,
Erik

> Tested with gc_test_suite with UseDynamicGCThreads turned on.
> 
> Thanks.
> 
> Jon



More information about the hotspot-gc-dev mailing list