Request for Review (xs) - 8024945: Remove check on minimum size of MetaspaceSiz

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jun 14 07:32:33 UTC 2016


Hi,

On Mon, 2016-06-13 at 15:43 -0700, Jon Masamitsu wrote:
> 
> On 06/13/2016 03:29 PM, Kim Barrett wrote:
> > 
> > > 
> > > On Jun 13, 2016, at 5:56 PM, Jon Masamitsu <jon.masamitsu at oracle.
> > > com> wrote:
> > > 
> > > https://bugs.openjdk.java.net/browse/JDK-8024945
> > > 
> > > Previous to this change the smallest MetaspaceSize value allowed
> > > was 256k.  There is not reason for the restriction so this change
> > > removes it.  A very small MetaspaceSize  (even 0) does not cause
> > > a problem because during initialization a GC is not triggered
> > > unless
> > > the Metaspace needed grows beyond MaxMetaspaceSize.
> > > 
> > > http://cr.openjdk.java.net/~jmasa/8024945/webrev.00/
> > > 
> > > Tested with -XX:MetaspaceSize=0.  General testing with
> > > gc_test_suite.
> > Looks good.
> Thanks.
> 
> > 
> > -----------------------------------------------------------------
> > -------------
> > test/gc/metaspace/TestMetaspaceInitialization.java
> > 27  * @bug 8042933
> > 
> > Should this be updated to also mention 8024945?
> Ah, yes.
> 
> Fixed.

  looks good to me with this mentioned change.

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list