RFR: 8158412: [TESTBUG] TestIHOPErgo and TestStressG1Humongous should not be executed when JFR is enabled

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jun 14 12:22:00 UTC 2016


Hi Mikael,

On Wed, 2016-06-08 at 16:49 +0300, Michail Chernov wrote:
> Hi,
> 
> Could I have a reviews for this small fix? The fix adds new custom
> JTreg 
> setting for @requires tag - vm.FlightRecorder. New setting is used
> in 
> all updated tests. Tests will be exclude if JFR is enabled.
> 
> https://bugs.openjdk.java.net/browse/JDK-8158412
> http://cr.openjdk.java.net/~mchernov/8158412/webrev.root.00/
> http://cr.openjdk.java.net/~mchernov/8158412/webrev.hotspot.00/
> 
> Testing - RBT.

  seems okay, however the syntax to use vm.FlightRecorder seems
awkward, i.e.

"vm.FlighRecorder != true"

Isn't there a way to make it something more common like
!vm.FlightRecorder?

Not insisting on this, just asking.

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list