RFR: 8149128: Add tests for G1MMUTracker

[Jesper Wilhelmsson]

Looks good!
/Jesper

Den 17/6/16 kl. 12:15, skrev Erik Helin:
> On 2016-06-01, Kim Barrett wrote:
>>> On May 24, 2016, at 11:09 AM, Erik Helin <erik.helin at oracle.com> wrote:
>>>
>>> Hi all,
>>>
>>> we have a new shiny unit test framework so I figured I would take it for
>>> a spin. I added some new tests for G1MMUTracker, see below. If you want
>>> to try out the new test runner, just apply the patch, then:
>>>
>>>  $ make test-hotspot-gtest
>>>
>>> Enhancement:
>>> https://bugs.openjdk.java.net/browse/JDK-8149128
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ehelin/8149128/00/
>>>
>>> Testing:
>>> - JPRT
>>> - Running locally on Linux x86-64
>>>
>>> Thanks,
>>> Erik
>>>
>>> PS. I don't really how if the feature complete applies to tests?
>>
>> ------------------------------------------------------------------------------
>> I find it quite confusing to have a class called ms that constructs
>> from a millisecond time, but implicitly converts to double seconds.
>
> Yeah, that was a bit too magical :) I changed the test to use an
> ordinary function:
>
> - incremental: http://cr.openjdk.java.net/~ehelin/8149128/00-01/webrev/
> - full: http://cr.openjdk.java.net/~ehelin/8149128/01/webrev/
>
>> ------------------------------------------------------------------------------
>> The following (convenience) functions are untested.
>> when_max_gc_sec
>> when_max_gc_ms
>> when_ms
>
> I plan to remove most of these, since they are barely used. For now I
> would like to not test them.
>
> Thanks,
> Erik
>