PING: RFR: JDK-8155730: HeapInfoDCmd should get Heap_lock

[Yasumasa Suenaga]

Thanks Thomas!

Can you push this change (after resolving new failure) ?
I want to ask to you what should I do.


Yasumasa


On 2016/06/16 21:15, Thomas Schatzl wrote:
> Hi Yasumasa,
>
> On Tue, 2016-06-14 at 00:13 +0900, Yasumasa Suenaga wrote:
>> Hi Thomas, Erik,
>>
>> I ran webrev.02 patch, thread dump (SIGQUIT), VM.info jcmd, and
>> generating hs_err log work fine
>> on my Fedora23 x64 with fastdebug JDK.
>>
>> Please tell me what test(s) failed.
>>
>
>   (new) test failures do not necessarily mean that there is something
> wrong with your patch. It only means that the system had some new
> unrecognized failure modes of some tests :)
>
> There is some automated failure matching with existing bugs, but that
> is not always correct.
>
> So in case of new failures we need to look through the failure logs and
> try to find out which of these failures are actually new failures.
> In this case, I could, with very high certainty rule out this change as
> the cause for all these failures. So, the change looks good after all.
>
> Thanks,
>   Thomas
>