RFR: 8159893: StringTable cleaning log line lacks the GC ID prefix

[kirk at kodewerk.com]

Hi Stefan,

The GC logs carry their own timers aside from the decorations provided by the logging framework. Should this entry also uses that timer?

Kind regards,
Kirk Pepperdine

> On Jun 21, 2016, at 1:58 PM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
> 
> Thanks, Jon.
> 
> StefanK
> 
> On 2016-06-20 18:08, Jon Masamitsu wrote:
>> Change looks good.
>> 
>> Jon
>> 
>> On 06/20/2016 05:55 AM, Stefan Karlsson wrote:
>>> Hi all,
>>> 
>>> Please review this patch to fix the log line of the StringTable cleaning:
>>> 
>>> http://cr.openjdk.java.net/~stefank/8159893/webrev.00/
>>> https://bugs.openjdk.java.net/browse/JDK-8159893
>>> 
>>> Before the patch:
>>> [4.591s][debug][gc,phases,start ] GC(7) Parallel Unloading (4.591s)
>>> [4.596s][info ][gc,stringtable  ] Cleaned string and symbol table, strings: 5899 processed, 0 removed, symbols: 34149 processed, 0 removed
>>> [4.596s][debug][gc,phases       ] GC(7) Parallel Unloading (4.591s, 4.596s) 4.902ms
>>> [4.596s][info ][gc              ] GC(7) Pause Remark 70M->70M(20480M) (4.578s, 4.596s) 18.161ms
>>> 
>>> After the patch:
>>> [4.591s][debug][gc,phases,start ] GC(7) Parallel Unloading (4.591s)
>>> [4.596s][info ][gc,stringtable  ] GC(7) Cleaned string and symbol table, strings: 5899 processed, 0 removed, symbols: 34149 processed, 0 removed
>>> [4.596s][debug][gc,phases       ] GC(7) Parallel Unloading (4.591s, 4.596s) 4.902ms
>>> [4.596s][info ][gc              ] GC(7) Pause Remark 70M->70M(20480M) (4.578s, 4.596s) 18.161ms
>>> 
>>> The TestStringSymbolTableStats test was update to match and test the new format.
>>> 
>>> Thanks,
>>> StefanK
>> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20160622/0994fdda/signature.asc>