Request for Review (xs) - 8159073: Error handling incomplete when creating GC threads lazily

[Jon Masamitsu]

The change has grown some (small now, not extra small).

Added logging for the case where thread creation fails.

http://cr.openjdk.java.net/~jmasa/8159073/webrev_delta_00_01a/

Added fixes for failed thread creation.

http://cr.openjdk.java.net/~jmasa/8159073/webrev_delta_00_01b/

Complete fix with test added.

http://cr.openjdk.java.net/~jmasa/8159073/webrev.01/

Tested with gc_test_suite with new diagnostic flag on and off.

Thanks.

Jon

On 6/21/2016 1:52 PM, Jon Masamitsu wrote:
>
>
> On 6/21/2016 12:22 PM, Derek White wrote:
>> On 6/9/16 4:33 AM, Erik Helin wrote:
>>> On 2016-06-08, Jon Masamitsu wrote:
>>>> https://bugs.openjdk.java.net/browse/JDK-8159073
>>>>
>>>> The error handling in add_workers() was not treating the 
>>>> non-initializing
>>>> case correctly.  If in the non-initializing case, it is OK to fail the
>>>> creation
>>>> of additional threads but the number of created threads should not be
>>>> incremented nor non-existent thread started.
>>>>
>>>> http://cr.openjdk.java.net/~jmasa/8159073/webrev.00/
>>> Should we add some logging in case the code fail to create a worker
>>> thread (in the non initializing case)?
>>>
>>> Thanks,
>>> Erik
>>>
>>>> Tested with gc_test_suite with UseDynamicGCThreads turned on.
>>>>
>>>> Thanks.
>>>>
>>>> Jon
>>
>>
>> Hi Jon,
>>
>> Looks good, but I agree with Eric that logging would be nice.
>
> Derek,
>
> Thanks for the review.  Unfortunately there is more code than I've
> fixed that need to tolerate thread creation failure so I'm still working
> on a complete fix.
>
> Jon
>>
>>  - Derek
>>
>