RFR: 8024137 - Flags should be set using the proper macro

[sangheon]

Hi Jesper,

On 06/21/2016 01:01 PM, Jesper Wilhelmsson wrote:
> Hi,
>
> Please review this change to make the GC ergonomics use 
> FLAG_SET_ERGO() instead of setting values directly in flags. This 
> change builds on the fix for JDK-8048093 and assumes that we will 
> remember that the flags was set on the command line.
>
> If you know of any other places where we assign a flag directly 
> without using FLAG_SET_ERGO() please let me know since it would make 
> sense to change all these places in this change.
Looks good.

The only place that I found is,
g1YoungGenSizer.cpp:48
     MaxNewSize = NewSize;

And I recommend you to run TestOptionsWithRanges.java for all platforms.
Your change seems okay with the test but it would be better to run it if 
we change flag related codes.

Thanks,
Sangheon


>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8024137
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8024137/webrev.00/
>
> Thanks,
> /Jesper
>