Request for Review (s) - 8149343: assert(rp->num_q() == no_of_gc_workers) failed: sanity
Jon Masamitsu
jon.masamitsu at oracle.com
Fri Mar 18 18:39:17 UTC 2016
New versions of the webrev's
Changes from 01
http://cr.openjdk.java.net/~jmasa/8149343/webrev_delta.01_02/
Complete
http://cr.openjdk.java.net/~jmasa/8149343/webrev.02/
This wrong indentation does not show as changed lines
in the webrev but if you look for them, they are fixed in 02.
> ------------------------------------------------------------------------------
> src/share/vm/gc/shared/referenceProcessor.cpp
> 723 total_refs += ref_lists[i].length();
> 724 }
> 725 log_reflist_counts(ref_lists, _max_num_q, total_refs);
>
> 788 balanced_total_refs += ref_lists[i].length();
> 789 }
> 790 log_reflist_counts(ref_lists, _num_q, balanced_total_refs);
Thanks.
Jon
On 3/17/2016 10:46 AM, Kim Barrett wrote:
>> On Mar 16, 2016, at 6:42 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>>
>> The change to re-initialize _next_id passed testing so is now
>> the proposed fix.
>>
>> Delta from original fix:
>> http://cr.openjdk.java.net/~jmasa/8149343/webrev_delta.00_01/
>>
>> Full fix version 01
>> http://cr.openjdk.java.net/~jmasa/8149343/webrev.01/
> This seems to have dealt with the _next_id issue, but the other issues from my initial review are still there.
>
More information about the hotspot-gc-dev
mailing list