RFR (XXS): 8156660: JDK-8150393 does not set _scan_in_progress properly

Mikael Gerdin mikael.gerdin at oracle.com
Tue May 10 12:57:59 UTC 2016


Hi,

On 2016-05-10 14:53, Thomas Schatzl wrote:
> Hi all,
>
>    could I have reviews for this bug introduced in JDK-8150393 that
> unconditionally sets G1CMRootRegions::_scan_in_progress to true when
> preparing for root region scan?
>
> The change causes some perf issue (since we are starting up threads
> doing nothing), but with JDK-8155810 this causes a guarantee to fail (I
> noticed this issue when testing JDK-8155810).
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8156660
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8156660/webrev

Sorry for introducing this bug :(

Fix looks good.
/Mikael

> Testing:
> jprt (running), local testing
>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list