RFR(S): 8132713: Add tests which check that Humongous objects behave as expected after finishing ConcMark Cycle

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Wed May 11 11:07:31 UTC 2016


Hi Kirill,

The fix looks good to me.
One minor suggestion:

-Xlog:gc=
-->
-Xlog:gc*=

In case of failure the more data available the better.
(I don't need a separate review for that change).


Thanks,
Dima


On 11.05.2016 13:42, Kirill Zhaldbybin wrote:
> Dear all,
>
> Could you please review this fix for 8132713?
>
> This fix adds two CMC scenarios to 
> gc/g1/humongousObjects/objectGraphTest/TestObjectGraphAfterGC.java 
> which creates different types of object graphs with Object arrays as 
> nodes (to make them humongous) and checks that after different types 
> GCs objects' graphs were handled correctly.
>
> During first CMC scenario the test expects that weakly reachable 
> non-humongous nodes which are not referenced by weakly reachable 
> humongous nodes should be collected and other weakly reachable nodes 
> should not be collected (since weakly reachable non-humongous nodes 
> are in young gen and during CMC they are handled as strong roots).
> During second CMC scenario the test expects that all weakly reachable 
> nodes should be collected since non-humongous nodes were previously 
> promoted to old gen.
> During both scenarios softly reachable nodes should not be collected.
>
> WebRev: 
> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8132713/webrev.00/
> CR: https://bugs.openjdk.java.net/browse/JDK-8132713
>
> Thank you.
>
> Regards, Kirill

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20160511/61e413e8/attachment.htm>


More information about the hotspot-gc-dev mailing list