RFR(S): 8132713: Add tests which check that Humongous objects behave as expected after finishing ConcMark Cycle

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Thu May 26 15:25:28 UTC 2016


Thomas,

Thank you for review!

Regards, Kirill

On 26.05.2016 17:14, Thomas Schatzl wrote:
> Hi,
>
> On Mi, 2016-05-11 at 13:42 +0300, Kirill Zhaldbybin wrote:
>> Dear all,
>>
>> Could you please review this fix for 8132713?
>>
>> This fix adds two CMC scenarios to
>> gc/g1/humongousObjects/objectGraphTest/TestObjectGraphAfterGC.java
>> which creates different types of object graphs with Object arrays as
>> nodes (to make them humongous) and checks that after different types
>> GCs objects' graphs were handled correctly.
>>
>> During first CMC scenario the test expects that weakly reachable
>> non-humongous nodes which are not referenced by weakly reachable
>> humongous nodes should be collected and other weakly reachable nodes
>> should not be collected (since weakly reachable non-humongous nodes
>> are in young gen and during CMC they are handled as strong roots).
>> During second CMC scenario the test expects that all weakly reachable
>> nodes should be collected since non-humongous nodes were previously
>> promoted to old gen.
>> During both scenarios softly reachable nodes should not be collected.
>>
>> WebRev:
>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8132713/webrev.00/
>> CR: https://bugs.openjdk.java.net/browse/JDK-8132713
>
>    Looks good.
>
> Thomas
>
>




More information about the hotspot-gc-dev mailing list