RFR (S): 8142749: HeapRegion cleanup

Thomas Schatzl thomas.schatzl at oracle.com
Tue May 31 11:49:18 UTC 2016


Hi,

On Mon, 2016-05-30 at 15:05 +0300, Всеволод Толстопятов wrote:
> Hi all,
> Please review and sponsor this change for JDK-8142749.
> Note that not only HeapRegion::_predicted_bytes_to_copy related code
> was removed, but also some unused (since the first commit)
> method/class parameters and HeapRegion::object_iterate_mem_careful
> method. All changed files contain at least several unused includes,
> but I'm not sure it's applicable to remove them in this patch.
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8142749
> Webrev: http://cr.openjdk.java.net/~fzhinkin/vtolstopyatov/8142749/we
> brev.00/
> Testing: hotspot_gc tests

  the change looks good, and I can sponsor it.

I see no reason to not remove the superfluous includes of the files you
are touching in this change.

Note that at the moment are past the JDK9 FC date, and we should not
integrate enhancements right now. There is no process at the moment if
and how these can be integrated. So it may take a while to push the
change.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list