RFR: 8167679: G1 phase logging is messy

Stefan Johansson stefan.johansson at oracle.com
Thu Nov 10 10:32:47 UTC 2016


Hi Erik,

On 2016-11-09 17:17, Erik Helin wrote:
> On 10/26/2016 10:15 AM, Stefan Johansson wrote:
>>
>>
>> On 2016-10-25 17:08, Thomas Schatzl wrote:
>>> Hi all,
>>>
>>> On Tue, 2016-10-25 at 17:04 +0200, Erik Helin wrote:
>>>> On 2016-10-25, Thomas Schatzl wrote:
>>>>> Hi Erik,
>>>>>
>>>>> On Tue, 2016-10-25 at 15:17 +0200, Erik Helin wrote:
>>> [...
>>>>> One suggestion: please move the sub-sections of the Free Collection
>>>>> Set
>>>>> phase into trace level. They look odd at the same level as the main
>>>>> category.
>>>> I agree, please see new patches at:
>>>> - incremental: http://cr.openjdk.java.net/~ehelin/8167679/01-02/
>>>> - full: http://cr.openjdk.java.net/~ehelin/8167679/02/
>>>    looks good. Ship it.
>> +1
>
> Ehem, I ran `make test TEST=hotspot_gc` and discovered that I forgot 
> to update the corresponding test when moving the sub-sections of the 
> Free Collection Set phase to trace level. Please see the following new 
> patch:
> - inc: http://cr.openjdk.java.net/~ehelin/8167679/02-03/
> - full: http://cr.openjdk.java.net/~ehelin/8167679/03/
>
Looks reasonable =)

StefanJ
> Thanks,
> Erik
>
>>> Thomas
>>>
>>




More information about the hotspot-gc-dev mailing list