RFR(XS): 8168934: [TESTBUG] gc/g1/logging/TestG1LoggingFailure.java failed
Michail Chernov
michail.chernov at oracle.com
Tue Nov 15 10:58:39 UTC 2016
Thanks for reviewing!
Michail
On 15/11/2016 09:20, Dmitry Fazunenko wrote:
> Hi Michail,
>
> On 14.11.2016 19:36, Michail Chernov wrote:
>> Hi,
>>
>> Could I have a reviews for this small change, please?
>>
>> http://cr.openjdk.java.net/~mchernov/8168934/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8168934
>>
>> Test expects that VM exits with exit code 1 and checks that output
>> contains message related to OOME. Actual test's target is to ensure
>> that VM exits and does not print 'pure virtual method called' [1][2].
>> Checking of what exactly VM prints on OOME is not the goal for this
>> test.
>
> I agree, this extra check is not needed here.
> The fix looks good.
>
> Thanks,
> Dima
>
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8146009
>> [2] https://bugs.openjdk.java.net/browse/JDK-8169634
>>
>> Thanks,
>> Michail
>
>
More information about the hotspot-gc-dev
mailing list