RFR (S/M): 8169703: G1 crashes with guarantee(pretouch_gang != NULL) failed: No pretouch gang specified

Thomas Schatzl thomas.schatzl at oracle.com
Mon Nov 21 20:29:14 UTC 2016


Hi Kim,

On Mon, 2016-11-21 at 15:11 -0500, Kim Barrett wrote:
> > 
> > On Nov 21, 2016, at 8:19 AM, Thomas Schatzl <thomas.schatzl at oracle.
> > com> wrote:
> > 
> > Hi everyone,
> > 
> >   thanks for your reviews.
> > 
> > Webrev incorporating your comments available at
> > http://cr.openjdk.java.net/~tschatzl/8169703/webrev.0_to_1/
> > http://cr.openjdk.java.net/~tschatzl/8169703/webrev.1/
> There were some comments from Dmitry Fazunenko (11/18) for which
> I don’t see any changes: see below.  Am I missing something?
> 
> > 
> > One comment inlined further down:
> > 
> > On Fri, 2016-11-18 at 23:31 +0300, Dmitry Fazunenko wrote:
> > > 
> > > 2) TestParallelAlwaysPreTouch.java
> > > 
> > > a)
> > > @run main ...
> > > -->
> > > @run main/othervm …
> I don’t see a change for this?
> 
> The jtreg documentation (http://openjdk.java.net/jtreg/tag-spec.html)
> says
> "If any <vm-opt>s are given then /othervm should be specified."
> 
> > 
> > > 
> > > b) You start one class, but declare another:
> > >  * @run main -Xms10M -Xmx100m ... TestAlwaysPreTouch
> > > public class Test2GbHeap {
> > > …
> > > }
> I don’t see a change for this?
> 
> 

  apologies, I messed up something when adding the -XX:+UseG1GC.

Dima probably reviewed the original change which had this.

Updated.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list