RFR(S): 8168492: Convert CollectedHeap_test to GTest
dmitry.fazunenko at oracle.com
Wed Nov 23 08:25:01 UTC 2016
the fix looks to me.
On 22.11.2016 18:01, Kirill Zhaldybin wrote:
> Thank you for review!
> I will change the formatting before pushing the fix.
> Regards, Kirill
> On 22.11.2016 16:41, Thomas Schatzl wrote:
>> Hi Kirill,
>> in case you need another review...
>>> On Nov 1, 2016, at 5:10 PM, Kirill Zhaldybin
>>> <kirill.zhaldybin at oracle.com> wrote:
>>>> Dear all,
>>>> Could you please review this fix for 8168492?
>>>> WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8168492/we
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8168492
>> In line
>> 47 ASSERT_LE(heap_end, ((uintptr_t) - 1 - epsilon))
>> the "-" in the "- 1" expression is an unary minus, not the regular
>> minus operator, so the space between it and the "1" should be removed.
>> Further the space between the uintptr_t cast and the unary minus seems
>> not appropriate.
>> I.e. the expression should look like "((uintptr_t)-1 - epsilon)" like
>> in the original code.
>> I do not need a re-review for this.
More information about the hotspot-gc-dev