RFR: 8167679: G1 phase logging is messy

[Erik Helin]

On 2016-10-25, Stefan Johansson wrote:
> Hi Erik,
> 
> On 2016-10-14 16:00, Erik Helin wrote:
> >Hi all,
> >
> >this patch re-organizes the slightly messy phase logging for G1.
> [snip]
> I really like the result of this change, I think this is a great
> improvement.

Thanks!

> >As for the code, I removed a few macros and replaced them with just
> >normal functions.
> >
> >Webrev:
> >http://cr.openjdk.java.net/~ehelin/8167679/00/
> Looks good in general, a few minor things:
> * I think we can skip the helper log_line, and instead used log_info,
> log_debug in similar to what is done for trace_line(size_t).

Agree, fixed.

> * Make it easier to see what's being logged by changing *_line(double) to
>   *_time and trace_line(size_t) to trace_count().

Agree, fixed.

> * The timing _recorded_clear_claimed_marks_time_ms is not added to sum_ms in
> print_post_evacuate_collection_set.

Agree, fixed.

Please see new patches at:
- incremental: http://cr.openjdk.java.net/~ehelin/8167679/00-01/
- full: http://cr.openjdk.java.net/~ehelin/8167679/01/

Thanks,
Erik

> Thanks,
> Stefan
> 
> >Bug:
> >https://bugs.openjdk.java.net/browse/JDK-8167679
> >
> >Testing:
> >- JPRT
> >
> >Thanks,
> >Erik
>