RFR: 8165451: Convert WorkerDataArray_test to GTest
Jesper Wilhelmsson
jesper.wilhelmsson at oracle.com
Tue Oct 25 13:54:54 UTC 2016
Still looks good!
/Jesper
Den 25/10/16 kl. 15:47, skrev Boris Molodenkov:
> Hi,
>
> The member initialization list didn't match the order of field declarations in
> the previous patch.
> It is fixed now.
> Please review it again:
> http://cr.openjdk.java.net/~bmoloden/8165451/webrev.02/
>
> Thanks,
> Boris
>
> On 04.10.2016 14:55, Jesper Wilhelmsson wrote:
>> Looks good!
>>
>> The copyright year in the new test file should be 2016 only.
>>
>> Thanks,
>> /Jesper
>>
>> Den 3/10/16 kl. 11:45, skrev Boris Molodenkov:
>>> Hi All,
>>>
>>> I still need review for that change.
>>>
>>> Thanks,
>>> Boris
>>>
>>> On 09/29/2016 05:35 PM, Boris Molodenkov wrote:
>>>> Hi,
>>>>
>>>> Test were changed according to Kirill's and Igor's comments.
>>>> Please review:
>>>> http://cr.openjdk.java.net/~bmoloden/8165451/webrev.01/
>>>>
>>>> Thanks,
>>>> Boris
>>>>
>>>> On 09/14/2016 06:47 PM, Boris Molodenkov wrote:
>>>>> Hi,
>>>>>
>>>>> Please review the following patch converting WorkerDataArray internal VM
>>>>> tests to GTest.
>>>>>
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8165451
>>>>> Webrev: http://cr.openjdk.java.net/~bmoloden/8165451/webrev.00/
>>>>>
>>>>> Thanks,
>>>>> Boris
>>>>>
>>>>
>>>
>
More information about the hotspot-gc-dev
mailing list