RFR(S): 8173335: Improve logging for j.l.ref.reference processing

sangheon sangheon.kim at oracle.com
Tue Aug 8 06:35:57 UTC 2017


Hi Aleksey,

On 08/07/2017 04:53 AM, Aleksey Shipilev wrote:
> On 08/04/2017 08:46 AM, sangheon wrote:
>> Webrev:
>> http://cr.openjdk.java.net/~sangheki/8173335/webrev.4 (full)
>> http://cr.openjdk.java.net/~sangheki/8173335/webrev.4_to_3b (inc)
> Looks good to me.
Thanks for the review.

>   It takes quite a bit of G1 in its sweep, but I guess G1 folks are fine with that?
>
> Minor nit:
>
>   *) In referenceProcessor.cpp, these line should be separated by a newline, because indenting is
> confusing:
>
>   195   ReferenceProcessorPhaseTimes* phase_times) {
>   196   double start_time = os::elapsedTime();
Okay, I will update this on next webrev.

Thanks,
Sangheon


>
> Thanks,
> -Aleksey
>




More information about the hotspot-gc-dev mailing list