RFR(S): 8173335: Improve logging for j.l.ref.reference processing
Thomas Schatzl
thomas.schatzl at oracle.com
Wed Aug 9 09:41:25 UTC 2017
Hi,
On Thu, 2017-08-03 at 23:46 -0700, sangheon wrote:
> Hi all,
>
> I had some discussions with Thomas and updated webrev with below
> items.
>
> 0. Agreed to use webrev.3b.
> 1. Moved ReferenceProcessorPhaseTimes from G1CollectedHeap to
> G1PhaseTimes.
> - Changed to stack allocate ReferenceProcessPhaseTimes in
> G1PhaseTimes.
> - ReferenceProcessorPhaseTimes is created from constructor of
> G1PhaseTimes.
> 2. Simplified the condition at
> G1GCPhaseTimes::debug_time_for_reference.
> 3. Removed ReferenceProcessorPhaseTimes::processing_is_mt() method.
> 4. Removed bool processing_is_mt from constructor of
> ReferenceProcessorPhaseTimes class.
> 5. Re-based code to latest source code.
> 6. Updated to use new log classes.
> 7. Some clean-ups in ReferenceProcessorPhaseTimes.
>
> Webrev:
> http://cr.openjdk.java.net/~sangheki/8173335/webrev.4 (full)
> http://cr.openjdk.java.net/~sangheki/8173335/webrev.4_to_3b (inc)
>
> Testing: JPRT
>
> Thanks,
> Sangheon
Please fix copyright date in g1DefaultPolicy.cpp and
g1DefaultPolicy.hpp.
otherwise looks good. I do not need a re-review for changing above.
Thanks,
Thomas
More information about the hotspot-gc-dev
mailing list