[10] RFR (XS): 8180366: [TESTBUG] gc/g1/humongousObjects/TestHumongousClassLoader should not be run with class unloading disabled

Dmitry Fazunenko dmitry.fazunenko at gmail.com
Wed Aug 9 21:40:32 UTC 2017


Hi Muthusamy,

To skip running a test if "-XX:-ClassUnloading" is given it's better to say:

@requires vm.opt.ClassUnloading != false

This will allow to keep the test running if no 'ClassUnloading' VM flag 
is specified.

Thanks,
Dima


On 09.08.2017 14:36, Muthusamy Chinnathambi wrote:
> Hi,
>
> Please review this trivial change for the fix of bug 'JDK-8180366 [TESTBUG] gc/g1/humongousObjects/TestHumongousClassLoader should not be run with class unloading disabled'
>
> Summary:
> This testcase(TestHumongousClassLoader.java) checks that unreachable classes and unreachable humongous class loader are unloaded after GC.  Hence we need to have class unloading enabled for the correctness of the test. The fix is to prohibit execution of the test if class unloading is disabled.
>
> jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8180366
> webrev link: http://cr.openjdk.java.net/~shshahma/Muthu/8180366/webrev.00/
>
> Testing: I have manually confirmed that jtreg will no longer run the test if -XX:-ClassUnloading is used.
>
> Regards,
> Muthusamy C

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20170810/2811ef29/attachment.htm>


More information about the hotspot-gc-dev mailing list