RFR: 8183281: Remove unnecessary call to increment_gc_time_stamp

Thomas Schatzl thomas.schatzl at oracle.com
Mon Jul 3 09:16:50 UTC 2017


Hi,

On Fri, 2017-06-30 at 11:37 +0200, Erik Helin wrote:
> Hi all,
> 
> the following small patch removes an unnecessary call to 
> increment_gc_time_stamp from 
> G1CollectedHeap::do_collection_pause_at_safepoint (and the long,
> wrong, 
> comment above the call).
> 
> We already do a call increment_gc_time_stamp much earlier in 
> do_collection_pause_at_safepoint, which is enough. The reasons
> outlined 
> in the comment motivating a second call is no longer true, the code
> has 
> changed (but the comment has not).
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8183281
> Patch: see below
> Testing: make hotspot
> 

  looks good.

Thomas




More information about the hotspot-gc-dev mailing list