RFR (XS): 8179677: Let G1Remset::_conc_refined_cards only count number of cards concurrently refined

Erik Helin erik.helin at oracle.com
Mon Jul 3 15:41:44 UTC 2017


On 07/03/2017 05:04 PM, Thomas Schatzl wrote:
> Hi all,
>
>   Erik asked for a few renamings and some additional comments. Here are
> the new webrevs:
> http://cr.openjdk.java.net/~tschatzl/8179677/webrev.1_to_2 (diff)
> http://cr.openjdk.java.net/~tschatzl/8179677/webrev.2 (full)

Looks good, Reviewed. Thanks Thomas!
Erik

> Thanks,
>   Thomas
>
> On Mon, 2017-07-03 at 11:58 +0200, Thomas Schatzl wrote:
>> Hi all,
>>
>>   can I have reviews for this small change that
>> makes G1Remset::_conc_refined_cards only count the number of
>> concurrently refined cards (+ some trivial renaming of the variable)?
>>
>> The reason is that I plan to add the number of refined cards during
>> gc
>> as separately soon. This has been suggested earlier in some internal
>> discussion, and I agree.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8179677
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8179677/webrev.1/
>> Testing:
>> jprt
>>
>> Thanks,
>>   Thomas



More information about the hotspot-gc-dev mailing list