RFR: 8179387: Factor out CMS specific code from GenCollectedHeap into its own subclass

Roman Kennke rkennke at redhat.com
Fri Jul 7 13:21:06 UTC 2017

Am 07.07.2017 um 14:35 schrieb Erik Helin:
> On 07/06/2017 06:23 PM, Roman Kennke wrote:
>>>>> Ok to push this?
>>> I just realized that your change doesn't build on Windows since you
>>> didn't #include "precompiled.hpp" in cmsHeap.cpp. MSVC is really picky
>>> about that.
>>> /Mikael
>> Uhhh.
>> Ok, here's revision #3 with precompiled added in:
>> http://cr.openjdk.java.net/~rkennke/8179387/webrev.03/
>> <http://cr.openjdk.java.net/%7Erkennke/8179387/webrev.03/>
> Hi Roman,
> I just started looking :) I think GenCollectedHeap::gc_prologue and
> GenCollectedHeap::gc_epilogue should be virtual, and
> always_do_update_barrier = UseConcMarkSweepGC moved down
> CMSHeap::gc_epilogue.
> What do you think?

Yes, I have seen that. My original plan was to leave it as is because I
know that Erik Ö. is working on a big barrier set refactoring that would
remove this code anyway. However, it doesn't really matter, here's the
cleaned up patch:



More information about the hotspot-gc-dev mailing list