RFR: 8179268: Factor out AdaptiveSizePolicy from top-level interfaces CollectorPolicy and CollectedHeap

Stefan Johansson stefan.johansson at oracle.com
Wed Jul 12 14:24:59 UTC 2017



On 2017-07-12 16:19, Per Liden wrote:
> Hi,
>
> On 2017-07-12 15:58, Roman Kennke wrote:
>>
>> That's a very good idea!! It alters behaviour slightly (will print
>> adaptive size policy stuff in hs_err now) but I think that's for the 
>> better.
>>
>> Incremental:
>> http://cr.openjdk.java.net/~rkennke/8179268/webrev.05.diff/
>> <http://cr.openjdk.java.net/%7Erkennke/8179268/webrev.05.diff/>
>> Full:
>> http://cr.openjdk.java.net/~rkennke/8179268/webrev.05
>> <http://cr.openjdk.java.net/%7Erkennke/8179268/webrev.05>
>>
>> Good now?
>
> Looks good. Not sure I follow your comment on hs_err. The adaptive 
> size policy stuff prints to the normal log (with gc+ergo=debug).
>
> Before pushing I'll take the liberty of removing the extra space you 
> added to the end of ParallelScavengeHeap::print_tracing_info().
>
>  586   AdaptiveSizePolicyOutput::print();
>  587
>  588 }
>
> Stefan, ok to push?
>
Yes, this looks great!

Thanks for cleaning this up Roman,
Stefan
> cheers,
> Per
>
>>
>> Thanks,
>> Roman
>>




More information about the hotspot-gc-dev mailing list