RFR (M): 8184346: Clean up G1CMBitmap

Thomas Schatzl thomas.schatzl at oracle.com
Fri Jul 14 12:09:40 UTC 2017


Hi Roman,

On Fri, 2017-07-14 at 13:24 +0200, Roman Kennke wrote:
> Am 14.07.2017 um 13:12 schrieb Aleksey Shipilev:
> > 
> > Hi Thomas,
> > 
> > On 07/14/2017 12:58 PM, Thomas Schatzl wrote:
> > > 
> > > > 
> > > > > 
> > > > > The next CR JDK-8184347 will deal with moving G1CMBitmap*
> > > > > into separate files.
> > > >  And while you're at it, you may want to move it to gc/shared
> > > > and renamed it to something like MarkBitmap?
> > > > https://bugs.openjdk.java.net/browse/JDK-8180193
> > > > 
> > > Not particularly against this change, but I think we should do
> > > the move and renaming separately when the change is actually
> > > required, i.e. just before there is another dependency on it.
> > I think this would be inconvenient, because when "another
> > dependency" would come in a large webrev, it would have to include
> > the CMBitmap move too, complicating reviews.
> I understood it such that we would post the moving around of gc/g1
> files to gc/shared right before we'd post Shenandoah (in the not-so-
> distant future, hopefully). That would work for me. I wouldn't like
> to include everything in a giant webrev :-P
> 

  that is exactly what I meant - thanks for your understanding.

Thomas




More information about the hotspot-gc-dev mailing list