RFR (XS): 8183538: UpdateRS phase should claim cards

Mikael Gerdin mikael.gerdin at oracle.com
Mon Jul 17 08:07:37 UTC 2017


Hi Thomas,

On 2017-07-13 13:35, Thomas Schatzl wrote:
> Hi,
> 
> On Thu, 2017-07-13 at 13:09 +0200, Erik Helin wrote:
>> Hi Thomas,
>>
>> On 07/12/2017 02:15 PM, Thomas Schatzl wrote:
>>>
>>> Hi all,
>>>
>>>    please review this small change that adds claiming of cards in
>>> the
>>> update rs phase so that scan rs does not rescan them.
>>>
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8183538
>>> Webrev:
>>> http://cr.openjdk.java.net/~tschatzl/8183538/webrev/
>> looks good, Reviewed.

Looks good to me as well.
/Mikael

>>
>> I was trying to find a way where we could utilize the claim_card
>> function, but could not come up with a good approach. Push this and
>> then we can see if we can reduce the slight code/logic duplication
>> later.
> 
>    yes, me too :) All variants I could think of would penalize one or
> the other phase.
> 
> Thanks for your review.
> 
> Thanks,
>    Thomas
> 



More information about the hotspot-gc-dev mailing list