RFR (XS): 8184452: Add bounds checking for FromCardCache

Thomas Schatzl thomas.schatzl at oracle.com
Mon Jul 17 08:33:10 UTC 2017


Hi Roman, Aleksey,

On Fri, 2017-07-14 at 13:20 +0200, Aleksey Shipilev wrote:
> On 07/14/2017 01:04 PM, Thomas Schatzl wrote:
> > 
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8184452/webrev/
> Looks good.

On Fri, 2017-07-14 at 13:15 +0200, Roman Kennke wrote:
> Am 14.07.2017 um 13:04 schrieb Thomas Schatzl:
>> > Hi all,
>> >   can I have reviews for this change that adds asserts/bounds
> > checking to the FromCardCache methods?
> > [...]
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8184452/webrev/
> > Testing:
> > jprt
>> > Thanks,
> >   Thomas
> 
> I'm all for more asserts if it helps to figure out bugs, so yes.
> Change looks good too.
> 
> Roman (not official reviewer)

  thanks for your reviews!

Thanks,
  Thomas





More information about the hotspot-gc-dev mailing list