RFR: G1HRRSFlushLogBuffersOnVerify with remembered set verification does not work

[Stefan Johansson]

Hi Erik,

On 2017-06-30 11:47, Erik Helin wrote:
> On 06/29/2017 11:37 AM, Thomas Schatzl wrote:
>>> Patch: http://cr.openjdk.java.net/~ehelin/8153360/00/
>>>
>>> Test: make hotspot - this is "just" removal of code
>>
>>   looks good.
>>
>> Please add a comment about what the last clause in the verification
>> code actually means (heapRegion.cpp:584). Something like:
>>
>> // Reference may not have been refined into the remembered sets yet.
>> // Instead of looking into all dirty card queues, we take a shortcut
>> // by looking at whether the corresponding card is dirty.
>> // ObjArrays may either by marked on the object header or exactly.
>>
>> (Actually I would guess the "correct" clause here would be is_array()
>> and not is_objArray(), but primitive type arrays are never marked as
>> they do not contain references)
>>
>> I do not need a re-review for the comment change.
>
> Thanks for the review Thomas, I will add the comment before I push!
After the comment removal in JDK-8183281 which referenced the flag I 
say: Ship it.

Thanks,
Stefan
> Erik
>
>> Thanks,
>>   Thomas
>>