RFR: 8171238: Unify cleanup code used in G1 Remark and Full GC marking
Per Liden
per.liden at oracle.com
Thu Mar 23 12:20:07 UTC 2017
Hi Stefan,
On 2017-02-23 14:47, Stefan Johansson wrote:
>
>
> On 2017-02-23 13:28, Thomas Schatzl wrote:
>> Hi,
>>
>> On Thu, 2017-02-23 at 11:40 +0100, Stefan Johansson wrote:
>> [....]
>>> New webrev:
>>> Full: http://cr.openjdk.java.net/~sjohanss/8171238/hotspot.01/
>>> Inc: http://cr.openjdk.java.net/~sjohanss/8171238/hotspot.00-01/
Patch looks good. Just one thing, please remove the now unused
G1StringDedup::unlink() function. No need for a new webrev on my part.
In some future cleanup patch it would also seem natural if we moved the
unlink_or_oops_do() function to a style similar to parallel_unlink() and
always have the caller decide what Task to call this form. But let's not
do that in this patch.
cheers,
Per
>>>
>>> Thanks,
>>> Stefan
>> looks good. Please fixup copyright dates before pushing ;)
> Will do!
> Thanks,
> Stefan
>> Thomas
>>
>
More information about the hotspot-gc-dev
mailing list