RFR (7xS): 8071280: Specialize HeapRegion::oops_on_card_seq_iterate_careful for use during concurrent refinement and updating the rset

[Kim Barrett]

> On May 8, 2017, at 7:23 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
>> On May 5, 2017, at 7:30 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>> 
>> New webrevs:
>> http://cr.openjdk.java.net/~tschatzl/8071280/webrev.0_to_1/ (diff)
>> http://cr.openjdk.java.net/~tschatzl/8071280/webrev.1/ (full)
> 
> Looks good.
> 
> Do the tails of block_size and block_size_during_gc remain similar through
> all of these cleanups?  If so, merging them into a common helper would be
> nice.  That can be a further cleanup if they do remain similar.

Oh, Sangheon mentioned the same thing and you replied that maybe block_size
should end up calling block_size_during_gc.  I think I’d prefer a common helper
function, rather than (to my mind) confusing things by having block_size call the
during_gc variant not during a (STW) gc.