[9, P1] RFR (S/M): 8180048: Interned string and symbol table leak memory during parallel unlinking

[Aleksey Shipilev]

On 05/12/2017 03:38 AM, David Holmes wrote:
> On 12/05/2017 2:26 AM, Aleksey Shipilev wrote:
>> Nits:
>>
>>  *) Modifier order?
>>   176   BasicHashtableEntry<F>* volatile _free_list;
> 
> _free_list is updated lock-free using Atomic::cmpxchg_ptr so it is appropriate
> to mark it as being volatile.

Of course. My comment was about the modifier _order_, see in the same file:

 176   BasicHashtableEntry<F>* volatile _free_list;
...
 180   volatile int      _number_of_entries;

I think Hotspot uses "volatile $type $id" everywhere I saw.

Thanks,
-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20170512/c210996b/signature.asc>