[PATCH] JDK-8176571: Fine bitmaps should be allocated as belonging to mtGC

Milan Mimica Milan.Mimica at infobip.com
Mon May 22 06:35:08 UTC 2017


Just fixing the subject


________________________________
From: hotspot-gc-dev <hotspot-gc-dev-bounces at openjdk.java.net> on behalf of Milan Mimica <Milan.Mimica at infobip.com>
Sent: Sunday, May 21, 2017 13:12
To: hotspot-gc-dev at openjdk.java.net
Subject: RFR(XS) JDK-8176571:


Hello


Here is my attempt to fix https://bugs.openjdk.java.net/browse/JDK-8176571. The same applies to jdk9 and 10.

It changes the NMT category of CHeapBitMap which is used only in G1 code. Given that the class is defined in "share" scope, and it may be used elsewhere in the future, perhaps it should be made made a template? That will add more boilerplate code to g1 sources.


--- old/src/share/vm/utilities/bitMap.cpp    2017-05-21 13:09:15.350905240 +0200
+++ new/src/share/vm/utilities/bitMap.cpp    2017-05-21 13:09:15.286905238 +0200
@@ -48,10 +48,10 @@
 class CHeapBitMapAllocator : StackObj {
  public:
   bm_word_t* allocate(size_t size_in_words) const {
-    return ArrayAllocator<bm_word_t, mtInternal>::allocate(size_in_words);
+    return ArrayAllocator<bm_word_t, mtGC>::allocate(size_in_words);
   }
   void free(bm_word_t* map, idx_t size_in_words) const {
-    ArrayAllocator<bm_word_t, mtInternal>::free(map, size_in_words);
+    ArrayAllocator<bm_word_t, mtGC>::free(map, size_in_words);
   }
 };

Milan Mimica, Senior Software Engineer / Division Lead

[Visit Infobip website]<http://www.infobip.com/?utm_source=Signature&utm_medium=Email&utm_campaign=Company>

Office: Mletacka 12/III, 52100 Pula, Croatia  |  Fax: +38552210979  |  Mobile: +385993061692

Email: Milan.Mimica at infobip.com  |  Skype: mmimicaib

[http://www.infobip.com/images/signatures/facebook.png]<https://www.facebook.com/infobip>[http://www.infobip.com/images/signatures/linked_in.png]<https://www.linkedin.com/company/infobip>[http://www.infobip.com/images/signatures/twitter.png]<https://twitter.com/Infobip>[http://www.infobip.com/images/signatures/instagram.png]<https://www.instagram.com/infobip/>

www.infobip.com<http://www.infobip.com>   /   GSMA Associate Member   /   Mobey Forum Member
This message is private and confidential. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Infobip d.o.o. If you have received this message in error, please notify us immediately via email to customer.support at infobip.com<mailto:customer.support at infobip.com> or telephone +442032864231.

Milan Mimica, Senior Software Engineer / Division Lead

[[image]]<http://www.infobip.com/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20170522/7edef7e7/attachment.htm>


More information about the hotspot-gc-dev mailing list