8191562: Missing include in gcArguments.cpp breaks minimal JVM build
rkennke at redhat.com
Tue Nov 21 11:49:51 UTC 2017
I think this change is trivial and can be pushed:
Final webrev (incl. Reviewed-by: line):
Can somebody please sponsor it?
> Hi Martin,
> no, I don't think this is necessary. We can sneak it into this change:
> Is that what aix needs?
>> Hi Roman,
>> unfortunately, I was checking AIX too late. There's another missing
>> We need to #include "memory/allocation.inline.hpp". Otherwise xlC
>> doesn't find a definition for the new/delete operators like
>> CHeapObj<F>::operator new.
>> Do you want me to open a new bug for it?
>> Best regards,
>> -----Original Message-----
>> From: hotspot-gc-dev [mailto:hotspot-gc-dev-bounces at openjdk.java.net]
>> On Behalf Of Roman Kennke
>> Sent: Montag, 20. November 2017 11:37
>> To: hotspot-gc-dev at openjdk.java.net
>> Subject: RFR: 8191562: Missing include in gcArguments.cpp breaks
>> minimal JVM build
>> David Holmes reported build failures in minimal JVM due to missing
>> include in gcArguments.cpp:
>> This should fix it:
>> Unfortunately, the minimal JVM doesn't build at all for me (*), so I am
>> posting this blindly. However, it seems fairly obvious that it's
>> correct: UNSUPPORTED_OPTION is defined in arguments.hpp, including it
>> should fix the build failure.
>> Ok to go?
>> In member function 'int StubAssembler::call_RT(Register, Register,
>> address, int)':
>> error: 'call_offset' may be used uninitialized in this function
>> return call_offset;
>> cc1plus: all warnings being treated as errors
More information about the hotspot-gc-dev