RFR: 8189733: Cleanup Full GC setup and tear down

Stefan Johansson stefan.johansson at oracle.com
Wed Nov 22 15:39:08 UTC 2017

Thanks Thomas for the review,

I got some comments from Erik and have updated the review accordingly. 
Here are the new webrevs:
Full: http://cr.openjdk.java.net/~sjohanss/8189733/01/
Inc: http://cr.openjdk.java.net/~sjohanss/8189733/00-01/

This change removes the heap() function as it's only used by member 
functions which can use _heap. Also changed the initialization list to 
use the parameters rather than the members initialized.


On 2017-11-16 09:31, Thomas Schatzl wrote:
> Hi,
> On Wed, 2017-11-15 at 17:24 +0100, Stefan Johansson wrote:
>> Hi,
>> Please review this enhancement:
>> https://bugs.openjdk.java.net/browse/JDK-8189733
>> Webrev:
>> http://cr.openjdk.java.net/~sjohanss//8189733/00/index.html
>> Summary:
>> After the G1FullCollector has been introduced as part of JEP 307 it
>> makes sense to move more of the setup and tear down for the Full GC
>> into
>> this class. The G1FullGCScope is also moved into the G1FullCollector
>> since it is now only used here.
>    looks good.
> Thomas

More information about the hotspot-gc-dev mailing list