RFR (S): 8188919: Generalize GC thread suspend/resume at safepoints

Erik Osterlund erik.osterlund at oracle.com
Mon Oct 9 16:24:11 UTC 2017


Hi Roman,

Thanks for the review. I will rebase this on that changeset once it is pushed.

Thanks,
/Erik

> On 9 Oct 2017, at 17:46, Roman Kennke <rkennke at redhat.com> wrote:
> 
>> Am 09.10.2017 um 17:35 schrieb Erik Österlund:
>> Hi,
>> 
>> When we synchronize/unsynchronize safepoints, we make sure to perform corresponding suspend/resume calls to GC-specific concurrent workers that may interfere with the safepoint. This is currently done by dumping GC-specific callbacks right in SafepointSynchronize::begin() and SafepointSynchronize::end(). The purpose with this cleanup is to hide this behind a general interface on CollectedHeap instead.
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8188919/webrev.00/
>> 
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8188919
>> 
>> Thanks,
>> /Erik
> 
> I like it.
> 
> It's going to conflict with this almost-pushed changeset though:
> 
> https://bugs.openjdk.java.net/browse/JDK-8179387
> 
> In fact, I think it's be cleaner to base your patch on this one.
> 
> Roman
> 
> 




More information about the hotspot-gc-dev mailing list