[8u] RFR for backport of JDK-8148175: C1: G1 barriers don't preserve FP registers to jdk8u-dev

[Vladimir Kozlov]

Good.

Thanks,
Vladimir

On 10/13/17 3:53 AM, Muthusamy Chinnathambi wrote:
> Hi Vladimir,
> 
>> Why do you need to add test explicitly to hotspot_compiler group?
>> It should be included implicitly into compact1_minimal group as other compiler/ tests. And compact1_minimal should be used in all other
>> testing.
> You are right, it should get picked implicitly as part of compact1_minimal group.
> 
>> Did you check that the test is executed without you modifying TEST.groups?
> Now - yes. Without my TEST.groups modification the test gets executed.
> 
> I will drop the change in TEST.groups file.
> Please note, this request is only for 8u.
> 
> Regards,
> Muthusamy C
> 
> -----Original Message-----
> From: Vladimir Kozlov
> Sent: Thursday, October 12, 2017 11:20 PM
> To: Muthusamy Chinnathambi <muthusamy.chinnathambi at oracle.com>; hotspot compiler <hotspot-compiler-dev at openjdk.java.net>; hotspot-gc-dev at openjdk.java.net
> Subject: Re: [8u] RFR for backport of JDK-8148175: C1: G1 barriers don't preserve FP registers to jdk8u-dev
> 
> Why do you need to add test explicitly to hotspot_compiler group?
> It should be included implicitly into compact1_minimal group as other compiler/ tests. And compact1_minimal should be
> used in all other testing. Did you check that the test is executed without you modifying TEST.groups?
> 
> Thanks,
> Vladimir K
> 
> On 10/12/17 3:46 AM, Muthusamy Chinnathambi wrote:
>> May I please get a second review for the change.
>>
>> Regards,
>> Muthusamy C
>>
>> -----Original Message-----
>> From: Vladimir Ivanov
>> Sent: Wednesday, October 11, 2017 5:29 PM
>> To: Muthusamy Chinnathambi <muthusamy.chinnathambi at oracle.com>
>> Cc: hotspot-gc-dev at openjdk.java.net; hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
>> Subject: Re: [8u] RFR for backport of JDK-8148175: C1: G1 barriers don't preserve FP registers to jdk8u-dev
>>
>> Looks good.
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> On 10/11/17 12:33 PM, Muthusamy Chinnathambi wrote:
>>> Hi,
>>> 		
>>> Please review the backport of bug: "JDK-8148175: C1: G1 barriers don't preserve FP registers" to jdk8u-dev
>>>
>>> Please note that this is not a clean backport due to new entries in TEST.groups and copyright changes.
>>>
>>> Webrev: http://cr.openjdk.java.net/~mchinnathamb/8148175/webrev.00/
>>> jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8148175
>>> Original patch pushed to jdk9: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a9334e785873
>>>
>>> Test:  Run jtreg and jprt hotspot testsets.
>>>
>>> Regards,
>>> Muthusamy C
>>>