RFR (S): 8189355: Cleanup of BarrierSet barrier functions

[Aleksey Shipilev]

Hi Erik,

On 10/17/2017 12:27 PM, Erik Österlund wrote:
> Webrev:
> http://cr.openjdk.java.net/~eosterlund/8189355/webrev.00/

Good patch, I scratched my head about the meaning about many of those methods when building the most
trivial BS for Epsilon:

http://hg.openjdk.java.net/jdk10/sandbox/hotspot/file/2e4b568252ea/src/share/vm/gc/epsilon/epsilonBarrierSet.hpp

Which also raises one observations:

 *) gen_write_ref_array_pre_barrier in stubGenerator_arm.cpp now has unconditional call to
BarrierSet::static_write_ref_array_pre, right? Epsilon returns "false" for
has_write_ref_pre_barrier. Is this something to be addressed by GC interface later?

Otherwise a very welcome cleanup!

Thanks,
-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20171017/95b55918/signature.asc>