RFR (S): 8189673: Consistent naming of concurrent threads, tasks and related identifiers

[White, Derek]

Hi Thomas,

That looks better!

Related to your goal:
The files are called g1ConcurrentMark.[cpp|hpp]. That's fine for now, but should there be a clarifying comment in the .hpp that class G1ConcurrentMark handles concurrent marking as well as X, Y, and Z?

Also a nit, but "marking_thread_num = scale_mark_threads(ParallelGCThreads)" sounds a little too "marky" after your changes.

Thanks,

- Derek

> -----Original Message-----
> From: hotspot-gc-dev [mailto:hotspot-gc-dev-bounces at openjdk.java.net]
> On Behalf Of Thomas Schatzl
> Sent: Monday, October 23, 2017 11:55 AM
> To: hotspot-gc-dev at openjdk.java.net
> Subject: RFR (S): 8189673: Consistent naming of concurrent threads, tasks
> and related identifiers
> 
> Hi,
> 
>   please review the following change that tries to consistently name
> concurrent workers and related members to not contain any of "marking",
> "mark", "parallel" or something similar, to use identifiers related to
> "concurrent workers".
> 
> The reason is that G1's concurrent worker threads for a long time now do
> more than strictly only "marking", but are also used for other, but typically
> related tasks.
> 
> Also, do not use "parallel" to avoid confusion with the work gang used
> during stw pauses. I think by now in the GC area the terms "concurrent"
> and "parallel" have a sufficiently distinct meaning to be useful.
> 
> Also change _max_worker_id to the more specific _max_num_tasks to not
> clash with the new naming. I.e. that it does not appear to be related to the
> concurrent workers.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8189673
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8189673/webrev/
> Testing:
> jprt
> 
> Thanks,
>   Thomas