RFR (S): 8189673: Consistent naming of concurrent threads, tasks and related identifiers

[White, Derek]

Thanks Thomas,

Thumbs up from me!

 - Derek

> -----Original Message-----
> From: Thomas Schatzl [mailto:thomas.schatzl at oracle.com]
> Sent: Tuesday, October 24, 2017 4:03 AM
> To: White, Derek <Derek.White at cavium.com>; hotspot-gc-
> dev at openjdk.java.net
> Subject: Re: RFR (S): 8189673: Consistent naming of concurrent threads,
> tasks and related identifiers
> 
> Hi,
> 
> On Mon, 2017-10-23 at 21:53 +0000, White, Derek wrote:
> > Hi Thomas,
> >
> > That looks better!
> >
> > Related to your goal:
> > The files are called g1ConcurrentMark.[cpp|hpp]. That's fine for now,
> > but should there be a clarifying comment in the .hpp that class
> > G1ConcurrentMark handles concurrent marking as well as X, Y, and Z?
> 
> I added a comment that it provides data structures for the concurrent cycle
> without going into detail.
> There may be significant changes soon ;)
> 
> > Also a nit, but "marking_thread_num =
> > scale_mark_threads(ParallelGCThreads)" sounds a little too "marky"
> > after your changes.
> 
> Fixed that, thanks.
> 
> New webrev:
> http://cr.openjdk.java.net/~tschatzl/8189673/webrev.1 (full)
> http://cr.openjdk.java.net/~tschatzl/8189673/webrev.0_to_1 (diff)
> Testing:
> local compilation
> 
> Thanks,
>   Thomas